summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOuadie EL FAROUKI <ouadie.elfarouki@codeplay.com>2024-04-05 14:35:06 +0100
committerGitHub <noreply@github.com>2024-04-05 19:05:06 +0530
commit1b496a745c315022df2d919374052e6004ced8d3 (patch)
tree255c32f9c398a88a0ca774bddd74811aadc4330a
parenta307375c02cac45cff53cf2520330b43fecc7718 (diff)
[SYCL] Fixed minor bug when enabling FP16 for non intel targets (#6464)
* moved INTEL_MKL guard from gemm_impl to gemm (wrapper) * Update ggml-sycl.cpp Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com> --------- Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com>
-rw-r--r--ggml-sycl.cpp21
1 files changed, 2 insertions, 19 deletions
diff --git a/ggml-sycl.cpp b/ggml-sycl.cpp
index 2b0e5f54..db3c24f6 100644
--- a/ggml-sycl.cpp
+++ b/ggml-sycl.cpp
@@ -1664,24 +1664,6 @@ namespace dpct
const void *alpha, const void *a, int lda, const void *b,
int ldb, const void *beta, void *c, int ldc)
{
-#ifndef __INTEL_MKL__
- GGML_UNUSED(q);
- GGML_UNUSED(a_trans);
- GGML_UNUSED(b_trans);
- GGML_UNUSED(m);
- GGML_UNUSED(n);
- GGML_UNUSED(k);
- GGML_UNUSED(alpha);
- GGML_UNUSED(a);
- GGML_UNUSED(lda);
- GGML_UNUSED(b);
- GGML_UNUSED(ldb);
- GGML_UNUSED(beta);
- GGML_UNUSED(c);
- GGML_UNUSED(ldc);
- throw std::runtime_error("The oneAPI Math Kernel Library (oneMKL) Interfaces "
- "Project does not support this API.");
-#else
Ts alpha_value = dpct::get_value(reinterpret_cast<const Ts *>(alpha), q);
Ts beta_value = dpct::get_value(reinterpret_cast<const Ts *>(beta), q);
auto data_a = get_memory<const Ta>(a);
@@ -1690,7 +1672,6 @@ namespace dpct
oneapi::mkl::blas::column_major::gemm(
q, a_trans, b_trans, m, n, k, alpha_value, data_a, lda,
data_b, ldb, beta_value, data_c, ldc);
-#endif
}
template <typename VecT, class BinaryOperation, class = void>
@@ -2330,6 +2311,7 @@ namespace dpct
lda, b, ldb, beta, c, ldc);
break;
}
+#ifdef __INTEL_MKL__
case detail::get_type_combination_id(
library_data_t::real_bfloat16, library_data_t::real_bfloat16,
library_data_t::real_float, library_data_t::real_float):
@@ -2391,6 +2373,7 @@ namespace dpct
q, a_trans, b_trans, m, n, k, &alpha_float, a, lda, b, ldb, &beta_float, c, ldc);
break;
}
+#endif // __INTEL_MKL__
default:
throw std::runtime_error("the combination of data type is unsupported");
}