summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierrick Hymbert <pierrick.hymbert@gmail.com>2024-03-14 12:15:39 +0100
committerGitHub <noreply@github.com>2024-03-14 13:15:39 +0200
commit43241adf22e8231ffaf3827d2c9310cc0ffd5ac5 (patch)
tree51ed83c922fec3a0f4c225d45200fe69c2584c02
parenta44bc969e4cd62ca9f4332e17fe3c51f2093e7c6 (diff)
server: disable debug release type sanitizer, simplify trigger (#6047)
- increase time out for server - do not fail fast
-rw-r--r--.github/workflows/server.yml17
-rw-r--r--examples/server/tests/features/steps/steps.py9
2 files changed, 16 insertions, 10 deletions
diff --git a/.github/workflows/server.yml b/.github/workflows/server.yml
index e385e03f..5e38b354 100644
--- a/.github/workflows/server.yml
+++ b/.github/workflows/server.yml
@@ -25,17 +25,14 @@ jobs:
strategy:
matrix:
sanitizer: [ADDRESS, THREAD, UNDEFINED]
- build_type: [Debug, Release]
+ build_type: [Debug]
include:
- build_type: Release
sanitizer: ""
- exclude:
- - build_type: Release
- sanitizer: ADDRESS
- - build_type: Release
+ - build_type: Debug
sanitizer: THREAD
- - build_type: Release
- sanitizer: UNDEFINED
+ disabled_on_pr: true
+ fail-fast: false # While -DLLAMA_SANITIZE_THREAD=ON is broken
container:
image: ubuntu:latest
@@ -81,13 +78,14 @@ jobs:
- name: Tests
id: server_integration_tests
+ if: ${{ !matrix.disabled_on_pr || !github.event.pull_request }}
run: |
cd examples/server/tests
PORT=8888 ./tests.sh
- name: Slow tests
id: server_integration_tests_slow
- if: ${{ github.event.schedule != '' && matrix.build_type == 'Release' || github.event.inputs.slow_tests == 'true' }}
+ if: ${{ (github.event.schedule || github.event.inputs.slow_tests == 'true') && matrix.build_type == 'Release' }}
run: |
cd examples/server/tests
PORT=8888 ./tests.sh --stop --no-skipped --no-capture --tags slow
@@ -124,13 +122,14 @@ jobs:
- name: Tests
id: server_integration_tests
+ if: ${{ !matrix.disabled_on_pr || !github.event.pull_request }}
run: |
cd examples/server/tests
behave.exe --summary --stop --no-capture --exclude 'issues|wrong_usages|passkey' --tags llama.cpp
- name: Slow tests
id: server_integration_tests_slow
- if: ${{ github.event.schedule != '' || github.event.inputs.slow_tests == 'true' }}
+ if: ${{ (github.event.schedule || github.event.inputs.slow_tests == 'true') && matrix.build_type == 'Release' }}
run: |
cd examples/server/tests
behave.exe --stop --no-skipped --no-capture --tags slow
diff --git a/examples/server/tests/features/steps/steps.py b/examples/server/tests/features/steps/steps.py
index cfa9f96e..a59a52d2 100644
--- a/examples/server/tests/features/steps/steps.py
+++ b/examples/server/tests/features/steps/steps.py
@@ -119,6 +119,10 @@ def step_server_metrics(context):
def step_start_server(context):
start_server_background(context)
attempts = 0
+ max_attempts = 20
+ if 'GITHUB_ACTIONS' in os.environ:
+ max_attempts *= 2
+
while True:
with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock:
result = sock.connect_ex((context.server_fqdn, context.server_port))
@@ -126,7 +130,7 @@ def step_start_server(context):
print("\x1b[33;46mserver started!\x1b[0m")
return
attempts += 1
- if attempts > 20:
+ if attempts > max_attempts:
assert False, "server not started"
print(f"waiting for server to start, connect error code = {result}...")
time.sleep(0.1)
@@ -943,6 +947,9 @@ async def wait_for_health_status(context,
print(f"Starting checking for health for expected_health_status={expected_health_status}\n")
interval = 0.5
counter = 0
+ if 'GITHUB_ACTIONS' in os.environ:
+ timeout *= 2
+
async with aiohttp.ClientSession() as session:
while True:
async with await session.get(f'{base_url}/health', params=params) as health_response: