summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCuong Trinh Manh <nguoithichkhampha@gmail.com>2023-12-29 21:39:15 +0700
committerGitHub <noreply@github.com>2023-12-29 16:39:15 +0200
commit97bbca6e8522d18041fcde6c3d0907a52ce36446 (patch)
tree1c6881eba36c92b6931f4475e3ab6c6793592a69
parent4af4801566bc262a38fb77f51edf278ac323c2bd (diff)
cmake : fix ld warning duplicate libraries libllama.a (#4671)
* fix "ld: warning: ignoring duplicate libraries: '../libllama.a'" * fix warning in example.
-rw-r--r--common/CMakeLists.txt2
-rw-r--r--examples/llava/CMakeLists.txt2
-rw-r--r--examples/server/CMakeLists.txt2
-rw-r--r--tests/CMakeLists.txt4
4 files changed, 5 insertions, 5 deletions
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
index b5d5453d..f79acfef 100644
--- a/common/CMakeLists.txt
+++ b/common/CMakeLists.txt
@@ -65,4 +65,4 @@ endif()
target_include_directories(${TARGET} PUBLIC .)
target_compile_features(${TARGET} PUBLIC cxx_std_11)
-target_link_libraries(${TARGET} PRIVATE llama build_info)
+target_link_libraries(${TARGET} PRIVATE build_info PUBLIC llama)
diff --git a/examples/llava/CMakeLists.txt b/examples/llava/CMakeLists.txt
index 8ea3e5c8..48dae150 100644
--- a/examples/llava/CMakeLists.txt
+++ b/examples/llava/CMakeLists.txt
@@ -32,5 +32,5 @@ endif()
set(TARGET llava-cli)
add_executable(llava-cli llava-cli.cpp)
install(TARGETS llava-cli RUNTIME)
-target_link_libraries(llava-cli PRIVATE common llama llava ${CMAKE_THREAD_LIBS_INIT})
+target_link_libraries(llava-cli PRIVATE common llava ${CMAKE_THREAD_LIBS_INIT})
target_compile_features(llava PRIVATE cxx_std_11)
diff --git a/examples/server/CMakeLists.txt b/examples/server/CMakeLists.txt
index 859cd12c..81709e44 100644
--- a/examples/server/CMakeLists.txt
+++ b/examples/server/CMakeLists.txt
@@ -6,7 +6,7 @@ install(TARGETS ${TARGET} RUNTIME)
target_compile_definitions(${TARGET} PRIVATE
SERVER_VERBOSE=$<BOOL:${LLAMA_SERVER_VERBOSE}>
)
-target_link_libraries(${TARGET} PRIVATE common llama llava ${CMAKE_THREAD_LIBS_INIT})
+target_link_libraries(${TARGET} PRIVATE common llava ${CMAKE_THREAD_LIBS_INIT})
if (WIN32)
TARGET_LINK_LIBRARIES(${TARGET} PRIVATE ws2_32)
endif()
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 9b5e69d1..7c932240 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -2,7 +2,7 @@ function(llama_build_executable source)
get_filename_component(TEST_TARGET ${source} NAME_WE)
add_executable(${TEST_TARGET} ${source})
install(TARGETS ${TEST_TARGET} RUNTIME)
- target_link_libraries(${TEST_TARGET} PRIVATE llama common)
+ target_link_libraries(${TEST_TARGET} PRIVATE common)
endfunction()
function(llama_test_executable name source)
@@ -14,7 +14,7 @@ function(llama_build_and_test_executable source)
get_filename_component(TEST_TARGET ${source} NAME_WE)
add_executable(${TEST_TARGET} ${source})
install(TARGETS ${TEST_TARGET} RUNTIME)
- target_link_libraries(${TEST_TARGET} PRIVATE llama common)
+ target_link_libraries(${TEST_TARGET} PRIVATE common)
add_test(NAME ${TEST_TARGET} COMMAND $<TARGET_FILE:${TEST_TARGET}> ${ARGN})
endfunction()