From 665018c749101e81c816675198e731e47d6b1dbe Mon Sep 17 00:00:00 2001 From: shibe2 Date: Mon, 2 Oct 2023 23:26:15 +0400 Subject: CLBlast: Add broadcast support for matrix multiplication (#3402) Broadcast src0 into src1 across dimensions 2 and 3 when needed. This is required for models that use GQA. --- ggml.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'ggml.c') diff --git a/ggml.c b/ggml.c index 820fe2e7..bf1426d2 100644 --- a/ggml.c +++ b/ggml.c @@ -11621,11 +11621,6 @@ static void ggml_compute_forward_mul_mat( #if defined(GGML_USE_CLBLAST) if (ggml_cl_can_mul_mat(src0, src1, dst)) { - // TODO: handle case when src0 is broadcast-able into src1 across 2nd,3rd dimension - // ref: https://github.com/ggerganov/ggml/pull/224 - GGML_ASSERT(ne02 == ne12); - GGML_ASSERT(ne03 == ne13); - if (params->ith == 0 && params->type == GGML_TASK_COMPUTE) { ggml_cl_mul_mat(src0, src1, dst, params->wdata, params->wsize); } -- cgit v1.2.3