GUI change:

- methods OnInitDialog, OnApply & OnClose of CDlgBase now return true if successful. return of false prevents a dialog from being loaded or left respectively;
- massive code cleaning considering the 'virtual' attribute of overridden methods;
- also fixes #1476 (Don't close "Create new account" window if user not set account name)

1 files changed, 2 insertions, 1 deletions

diff --git a/protocols/IcqOscarJ/src/askauthentication.cpp b/protocols/IcqOscarJ/src/askauthentication.cpp
index 998390767e..1afcac4f89 100644
--- a/protocols/IcqOscarJ/src/askauthentication.cpp
+++ b/protocols/IcqOscarJ/src/askauthentication.cpp
@@ -43,13 +43,14 @@ public:
 		m_btnOk.OnClick = Callback(this, &AskAuthProcDlg::onOk);

 	}

 

-	virtual void OnInitDialog()

+	bool OnInitDialog() override

 	{

 		if (!m_hContact || !m_proto->icqOnline())

 			EndDialog(m_hwnd, 0);

 

 		m_auth.SendMsg(EM_LIMITTEXT, 255, 0);

 		m_auth.SetText(TranslateT("Please authorize me to add you to my contact list."));

+		return true;

 	}

 

 	void onOk(CCtrlButton*)