diff options
author | George Hazan <george.hazan@gmail.com> | 2016-05-13 20:27:01 +0000 |
---|---|---|
committer | George Hazan <george.hazan@gmail.com> | 2016-05-13 20:27:01 +0000 |
commit | 690f3c5828685ffc3c2a11d8d68e4c0b1cf5f0ba (patch) | |
tree | 6fe6df105c8ffcefb5e3c0bfe59b14bfa2d1acbe /protocols/IcqOscarJ/src/fam_13servclist.cpp | |
parent | 37c98eaad76b7f1bf86c75fe2c32cf6aa11f7c6f (diff) |
major memory leak in ICQ cookie module
git-svn-id: http://svn.miranda-ng.org/main/trunk@16829 1316c22d-e87f-b044-9b9b-93d7a3e3ba9c
Diffstat (limited to 'protocols/IcqOscarJ/src/fam_13servclist.cpp')
-rw-r--r-- | protocols/IcqOscarJ/src/fam_13servclist.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/protocols/IcqOscarJ/src/fam_13servclist.cpp b/protocols/IcqOscarJ/src/fam_13servclist.cpp index a447dfe7dc..3c11e20a7f 100644 --- a/protocols/IcqOscarJ/src/fam_13servclist.cpp +++ b/protocols/IcqOscarJ/src/fam_13servclist.cpp @@ -33,10 +33,9 @@ void CIcqProto::handleServCListFam(BYTE *pBuffer, size_t wBufferLength, snac_hea case ICQ_LISTS_ACK: // UPDATE_ACK if (wBufferLength >= 2) { WORD wError; - cookie_servlist_action* sc; - unpackWord(&pBuffer, &wError); + cookie_servlist_action *sc; if (FindCookie(pSnacHeader->dwRef, NULL, (void**)&sc)) { // look for action cookie debugLogA("Received expected server list ack, action: %d, result: %d", sc->dwAction, wError); FreeCookie(pSnacHeader->dwRef); // release cookie @@ -47,7 +46,7 @@ void CIcqProto::handleServCListFam(BYTE *pBuffer, size_t wBufferLength, snac_hea debugLogA("Server-List: Grouped action contains %d actions.", sc->dwGroupCount); pBuffer -= 2; // revoke unpack - if (wBufferLength != 2 * sc->dwGroupCount) + if ((int)wBufferLength != 2 * sc->dwGroupCount) debugLogA("Error: Server list ack does not contain expected amount of result codes (%u != %u)", wBufferLength / 2, sc->dwGroupCount); for (i = 0; i < sc->dwGroupCount; i++) { |