summaryrefslogtreecommitdiff
path: root/protocols
diff options
context:
space:
mode:
authorRobert Pösel <robyer@seznam.cz>2014-04-21 14:50:39 +0000
committerRobert Pösel <robyer@seznam.cz>2014-04-21 14:50:39 +0000
commit591b56b22064c79e685b02ad8df809112e0142f4 (patch)
treedd60a0c78f8b0b6c1d0f5c312650311503ce34ef /protocols
parent1506353f98b6f2862ae0d701b837b4378ed0b620 (diff)
Facebook: Send typing notifications even to offline contacts
git-svn-id: http://svn.miranda-ng.org/main/trunk@9010 1316c22d-e87f-b044-9b9b-93d7a3e3ba9c
Diffstat (limited to 'protocols')
-rw-r--r--protocols/FacebookRM/src/json.cpp2
-rw-r--r--protocols/FacebookRM/src/messages.cpp5
2 files changed, 3 insertions, 4 deletions
diff --git a/protocols/FacebookRM/src/json.cpp b/protocols/FacebookRM/src/json.cpp
index cd9d6f286a..743d2380bd 100644
--- a/protocols/FacebookRM/src/json.cpp
+++ b/protocols/FacebookRM/src/json.cpp
@@ -607,7 +607,7 @@ int facebook_json_parser::parse_messages(void* data, std::vector< facebook_messa
facebook_user fbu;
fbu.user_id = json_as_pstring(from);
- MCONTACT hContact = proto->AddToContactList(&fbu, CONTACT_FRIEND);
+ MCONTACT hContact = proto->AddToContactList(&fbu, CONTACT_FRIEND); // only friends are able to send typing notifications
JSONNODE *st = json_get(it, "st");
if (json_as_int(st) == 1)
diff --git a/protocols/FacebookRM/src/messages.cpp b/protocols/FacebookRM/src/messages.cpp
index 31ffbc4c28..20b66f14c4 100644
--- a/protocols/FacebookRM/src/messages.cpp
+++ b/protocols/FacebookRM/src/messages.cpp
@@ -130,9 +130,8 @@ void FacebookProto::SendTypingWorker(void *p)
send_typing *typing = static_cast<send_typing*>(p);
- // TODO: don't send typing when we are not online?
- // Dont send typing notifications to contacts, that are offline or not friends
- if (getWord(typing->hContact, "Status", 0) == ID_STATUS_OFFLINE || getWord(typing->hContact, FACEBOOK_KEY_CONTACT_TYPE, 0) != CONTACT_FRIEND) {
+ // Dont send typing notifications to not friends - Facebook won't give them that info anyway
+ if (getWord(typing->hContact, FACEBOOK_KEY_CONTACT_TYPE, 0) != CONTACT_FRIEND) {
delete typing;
return;
}