From 43ba08f91ea6e7a32e4a11418c434e1ea36314c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20P=C3=B6sel?= Date: Thu, 23 Mar 2017 20:37:38 +0100 Subject: MSN: Raised password length limit to 99 chars (fixes #658) It might be rewritten better to remove any limit though. --- protocols/MSN/src/msn_auth.cpp | 4 ++-- protocols/MSN/src/msn_opts.cpp | 21 +++++++++++---------- protocols/MSN/src/version.h | 2 +- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/protocols/MSN/src/msn_auth.cpp b/protocols/MSN/src/msn_auth.cpp index e16cdd38e0..4cc45d04a6 100644 --- a/protocols/MSN/src/msn_auth.cpp +++ b/protocols/MSN/src/msn_auth.cpp @@ -354,7 +354,7 @@ int CMsnProto::MSN_GetPassportAuth(void) if (db_get_static(NULL, m_szModuleName, "Password", szPassword, sizeof(szPassword))) return 0; - szPassword[16] = 0; + szPassword[99] = 0; time_t ts = time(NULL); @@ -1009,7 +1009,7 @@ bool CMsnProto::parseLoginPage(char *pszHTML, NETLIBHTTPREQUEST *nlhr, CMStringA char szPassword[100]; if (db_get_static(NULL, m_szModuleName, "Password", szPassword, sizeof(szPassword))) return false; - szPassword[16] = 0; + szPassword[99] = 0; post->Format("PPFT=%s&login=%s&passwd=%s", ptrA(mir_urlEncode(pPPFT)), ptrA(mir_urlEncode(MyOptions.szEmail)), ptrA(mir_urlEncode(szPassword))); diff --git a/protocols/MSN/src/msn_opts.cpp b/protocols/MSN/src/msn_opts.cpp index 6bd1191b8e..02f9706da4 100644 --- a/protocols/MSN/src/msn_opts.cpp +++ b/protocols/MSN/src/msn_opts.cpp @@ -89,12 +89,12 @@ static INT_PTR CALLBACK DlgProcMsnOpts(HWND hwndDlg, UINT msg, WPARAM wParam, LP SetDlgItemTextA(hwndDlg, IDC_HANDLE, proto->MyOptions.szEmail); - char tBuffer[MAX_PATH]; - if (!db_get_static(NULL, proto->m_szModuleName, "Password", tBuffer, sizeof(tBuffer))) { - tBuffer[16] = 0; - SetDlgItemTextA(hwndDlg, IDC_PASSWORD, tBuffer); + char szPassword[100]; + if (!db_get_static(NULL, proto->m_szModuleName, "Password", szPassword, sizeof(szPassword))) { + tBuffer[99] = 0; + SetDlgItemTextA(hwndDlg, IDC_PASSWORD, szPassword); } - SendDlgItemMessage(hwndDlg, IDC_PASSWORD, EM_SETLIMITTEXT, 16, 0); + SendDlgItemMessage(hwndDlg, IDC_PASSWORD, EM_SETLIMITTEXT, 99, 0); HWND wnd = GetDlgItem(hwndDlg, IDC_HANDLE2); DBVARIANT dbv; @@ -115,6 +115,7 @@ static INT_PTR CALLBACK DlgProcMsnOpts(HWND hwndDlg, UINT msg, WPARAM wParam, LP EnableWindow(GetDlgItem(hwndDlg, IDC_MAILER_APP), tValue); EnableWindow(GetDlgItem(hwndDlg, IDC_ENTER_MAILER_APP), tValue); + char tBuffer[MAX_PATH]; if (!db_get_static(NULL, proto->m_szModuleName, "MailerPath", tBuffer, sizeof(tBuffer))) SetDlgItemTextA(hwndDlg, IDC_MAILER_APP, tBuffer); @@ -514,12 +515,12 @@ static INT_PTR CALLBACK DlgProcAccMgrUI(HWND hwndDlg, UINT msg, WPARAM wParam, L CMsnProto* proto = (CMsnProto*)lParam; SetDlgItemTextA(hwndDlg, IDC_HANDLE, proto->MyOptions.szEmail); - char tBuffer[MAX_PATH]; - if (!db_get_static(NULL, proto->m_szModuleName, "Password", tBuffer, sizeof(tBuffer))) { - tBuffer[16] = 0; - SetDlgItemTextA(hwndDlg, IDC_PASSWORD, tBuffer); + char szPassword[100]; + if (!db_get_static(NULL, proto->m_szModuleName, "Password", szPassword, sizeof(szPassword))) { + tBuffer[99] = 0; + SetDlgItemTextA(hwndDlg, IDC_PASSWORD, szPassword); } - SendDlgItemMessage(hwndDlg, IDC_PASSWORD, EM_SETLIMITTEXT, 16, 0); + SendDlgItemMessage(hwndDlg, IDC_PASSWORD, EM_SETLIMITTEXT, 99, 0); DBVARIANT dbv; if (!proto->getWString("Place", &dbv)) { diff --git a/protocols/MSN/src/version.h b/protocols/MSN/src/version.h index dc1e361c94..5277e31e30 100644 --- a/protocols/MSN/src/version.h +++ b/protocols/MSN/src/version.h @@ -21,7 +21,7 @@ along with this program. If not, see . #define __MAJOR_VERSION 0 #define __MINOR_VERSION 12 #define __RELEASE_NUM 1 -#define __BUILD_NUM 3 +#define __BUILD_NUM 4 #include -- cgit v1.2.3