From d23b4b4b1ccc9549aa8fc12326e7d7f135f1ce39 Mon Sep 17 00:00:00 2001 From: MikalaiR Date: Fri, 2 Oct 2015 15:49:19 +0000 Subject: SmileyAdd: coverity fixes git-svn-id: http://svn.miranda-ng.org/main/trunk@15486 1316c22d-e87f-b044-9b9b-93d7a3e3ba9c --- plugins/SmileyAdd/src/customsmiley.cpp | 3 +-- plugins/SmileyAdd/src/smileyroutines.cpp | 2 +- plugins/SmileyAdd/src/smileys.cpp | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/SmileyAdd/src/customsmiley.cpp b/plugins/SmileyAdd/src/customsmiley.cpp index 0b725d6a9f..32a6f7ff25 100644 --- a/plugins/SmileyAdd/src/customsmiley.cpp +++ b/plugins/SmileyAdd/src/customsmiley.cpp @@ -75,7 +75,7 @@ bool SmileyCType::CreateTriggerText(char* text) if (len == 0) return false; unsigned reslen; - char* res = (char*)mir_base64_decode(text, &reslen); + ptrA res((char*)mir_base64_decode(text, &reslen)); if (res == NULL) return false; @@ -88,7 +88,6 @@ bool SmileyCType::CreateTriggerText(char* text) m_TriggerText = txt; mir_free(txt); - mir_free(res); return true; } diff --git a/plugins/SmileyAdd/src/smileyroutines.cpp b/plugins/SmileyAdd/src/smileyroutines.cpp index 5c09efd5ff..e5154dc051 100644 --- a/plugins/SmileyAdd/src/smileyroutines.cpp +++ b/plugins/SmileyAdd/src/smileyroutines.cpp @@ -221,7 +221,7 @@ void ReplaceSmileys(HWND hwnd, SmileyPackType* smp, SmileyPackCType* smcp, const TextDocument->Release(); RichEditOle->Release(); return; - } + } // fallthrough TextRange->Release(); diff --git a/plugins/SmileyAdd/src/smileys.cpp b/plugins/SmileyAdd/src/smileys.cpp index 740f359df6..b9ecbb121a 100644 --- a/plugins/SmileyAdd/src/smileys.cpp +++ b/plugins/SmileyAdd/src/smileys.cpp @@ -238,7 +238,7 @@ void SmileyPackType::AddTriggersToSmileyLookup(void) m_SmileyList[dist].m_InsertText = out; first = false; } - } + } // fallthrough } li = m0->getEndingIndex(); } -- cgit v1.2.3