From 391980ce1e890445542441eeb5d9f9cc18ae1baf Mon Sep 17 00:00:00 2001 From: George Hazan Date: Fri, 26 Jan 2018 22:31:20 +0300 Subject: code optimization --- plugins/MenuItemEx/src/options.cpp | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) (limited to 'plugins/MenuItemEx/src/options.cpp') diff --git a/plugins/MenuItemEx/src/options.cpp b/plugins/MenuItemEx/src/options.cpp index 997bc2d417..853fdb40d8 100644 --- a/plugins/MenuItemEx/src/options.cpp +++ b/plugins/MenuItemEx/src/options.cpp @@ -35,25 +35,19 @@ INT_PTR CALLBACK OptionsProc(HWND hdlg, UINT msg, WPARAM wparam, LPARAM lparam) switch (msg) { case WM_INITDIALOG: - TranslateDialogDefault(hdlg); - for (i = 0; i < _countof(checkboxes); i++) - { - CheckDlgButton(hdlg, checkboxes[i].idc, (flags & checkboxes[i].flag) ? BST_CHECKED : BST_UNCHECKED); - } + for (auto &it : checkboxes) + CheckDlgButton(hdlg, it.idc, (flags & it.flag) ? BST_CHECKED : BST_UNCHECKED); - if (bPopupService) - { - for (i = 0; i < 4; i++) - { + if (bPopupService) { + for (i = 0; i < 4; i++) { GetDlgItemText(hdlg, checkboxes[i].idc, buffer, (_countof(buffer) - 3)); mir_wstrcat(buffer, L" *"); SetDlgItemText(hdlg, checkboxes[i].idc, buffer); } } - else - ShowWindow(GetDlgItem(hdlg, IDC_HINT1), SW_HIDE); + else ShowWindow(GetDlgItem(hdlg, IDC_HINT1), SW_HIDE); SendMessage(hdlg, WM_USER + 50, 0, 0); return 0; @@ -72,8 +66,8 @@ INT_PTR CALLBACK OptionsProc(HWND hdlg, UINT msg, WPARAM wparam, LPARAM lparam) case PSN_APPLY: DWORD mod_flags = 0; - for (i = 0; i < _countof(checkboxes); i++) - mod_flags |= IsDlgButtonChecked(hdlg, checkboxes[i].idc) ? checkboxes[i].flag : 0; + for (auto &it : checkboxes) + mod_flags |= IsDlgButtonChecked(hdlg, it.idc) ? it.flag : 0; db_set_dw(NULL, MODULENAME, "flags", mod_flags); return 1; -- cgit v1.2.3