From 77a9ce1c7510cdf66bf038300ce57952748a3e05 Mon Sep 17 00:00:00 2001 From: George Hazan Date: Fri, 10 Apr 2015 14:25:42 +0000 Subject: - fix for CREOleCallback constructor; - unsafe strlen call removed; - fix for static buffer lengths git-svn-id: http://svn.miranda-ng.org/main/trunk@12736 1316c22d-e87f-b044-9b9b-93d7a3e3ba9c --- plugins/Scriver/src/msgs.cpp | 12 ++++++------ plugins/Scriver/src/msgs.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'plugins/Scriver/src') diff --git a/plugins/Scriver/src/msgs.cpp b/plugins/Scriver/src/msgs.cpp index 910a7ee1dd..9d6724ed1e 100644 --- a/plugins/Scriver/src/msgs.cpp +++ b/plugins/Scriver/src/msgs.cpp @@ -599,19 +599,19 @@ STDMETHODIMP CREOleCallback::QueryInterface(REFIID riid, LPVOID * ppvObj) STDMETHODIMP_(ULONG) CREOleCallback::AddRef() { - if (refCount == 0) { - if (S_OK != StgCreateDocfile(NULL, STGM_READWRITE | STGM_SHARE_EXCLUSIVE | STGM_CREATE | STGM_DELETEONRELEASE, 0, &pictStg)) - pictStg = NULL; - nextStgId = 0; - } + if (refCount == 0) + StgCreateDocfile(NULL, STGM_READWRITE | STGM_SHARE_EXCLUSIVE | STGM_CREATE | STGM_DELETEONRELEASE, 0, &pictStg); + return ++refCount; } STDMETHODIMP_(ULONG) CREOleCallback::Release() { if (--refCount == 0) { - if (pictStg) + if (pictStg) { pictStg->Release(); + pictStg = NULL; + } } return refCount; } diff --git a/plugins/Scriver/src/msgs.h b/plugins/Scriver/src/msgs.h index cc991e6c87..cbd32beb0b 100644 --- a/plugins/Scriver/src/msgs.h +++ b/plugins/Scriver/src/msgs.h @@ -193,7 +193,7 @@ struct SrmmWindowData : public CommonWindowData struct CREOleCallback : public IRichEditOleCallback { - CREOleCallback() : refCount(0) {} + CREOleCallback() : refCount(0), nextStgId(0), pictStg(NULL) {} unsigned refCount; IStorage *pictStg; int nextStgId; -- cgit v1.2.3