Using INVALID_HANDLE_VALUE instead of -1 and fix for usedIcons (thanks ghazan)

git-svn-id: http://pescuma.googlecode.com/svn/trunk/Miranda@257 c086bb3d-8645-0410-b8da-73a8550f86e7

6 files changed, 12 insertions, 13 deletions

diff --git a/Plugins/extraicons/DefaultExtraIcons.cpp b/Plugins/extraicons/DefaultExtraIcons.cpp
index d1a03b4..3a7d068 100644
--- a/Plugins/extraicons/DefaultExtraIcons.cpp
+++ b/Plugins/extraicons/DefaultExtraIcons.cpp
@@ -343,7 +343,7 @@ static ProtoInfo *FindProto(const char * proto)
 		return NULL;

 

 	HANDLE hImage = (HANDLE) CallService(MS_CLIST_EXTRA_ADD_ICON, (WPARAM) hIcon, 0);

-	if (hImage == (HANDLE) -1)

+	if (hImage == INVALID_HANDLE_VALUE)

 		return NULL;

 

 	ProtoInfo tmp;

@@ -364,7 +364,7 @@ static int ProtocolApplyIcon(WPARAM wParam, LPARAM lParam)
 

 	ProtoInfo *pi = FindProto(proto);

 

-	HANDLE hImage = (HANDLE) -1;

+	HANDLE hImage = INVALID_HANDLE_VALUE;

 	if (pi != NULL)

 		hImage = pi->hImage;

 

diff --git a/Plugins/extraicons/ExtraIcon.cpp b/Plugins/extraicons/ExtraIcon.cpp
index a06fa6f..e681e31 100644
--- a/Plugins/extraicons/ExtraIcon.cpp
+++ b/Plugins/extraicons/ExtraIcon.cpp
@@ -67,7 +67,7 @@ void ExtraIcon::applyIcons()
 	while (hContact != NULL)

 	{

 		// Clear to assert that it will be cleared

-		Clist_SetExtraIcon(hContact, slot, (HANDLE) -1);

+		Clist_SetExtraIcon(hContact, slot, INVALID_HANDLE_VALUE);

 

 		applyIcon(hContact);

 

diff --git a/Plugins/extraicons/ExtraIconGroup.cpp b/Plugins/extraicons/ExtraIconGroup.cpp
index 162086e..797ccbe 100644
--- a/Plugins/extraicons/ExtraIconGroup.cpp
+++ b/Plugins/extraicons/ExtraIconGroup.cpp
@@ -134,10 +134,9 @@ int ExtraIconGroup::setIcon(int id, HANDLE hContact, void *icon)
 	}

 

 	if (storePos == items.size())

-	{

 		return -1;

-	}

-	else if (storePos > currentPos)

+

+	if (storePos > currentPos)

 	{

 		items[storePos]->storeIcon(hContact, icon);

 		return 0;

@@ -205,7 +204,7 @@ int ExtraIconGroup::getType() const
 

 int ExtraIconGroup::ClistSetExtraIcon(HANDLE hContact, HANDLE hImage)

 {

-	if (hImage != (HANDLE) -1)

+	if (hImage != INVALID_HANDLE_VALUE)

 		setValidExtraIcon = true;

 

 	return Clist_SetExtraIcon(hContact, slot, hImage);

diff --git a/Plugins/extraicons/IcolibExtraIcon.cpp b/Plugins/extraicons/IcolibExtraIcon.cpp
index 66ade61..56718af 100644
--- a/Plugins/extraicons/IcolibExtraIcon.cpp
+++ b/Plugins/extraicons/IcolibExtraIcon.cpp
@@ -46,7 +46,7 @@ void IcolibExtraIcon::applyIcon(HANDLE hContact)
 	if (!isEnabled() || hContact == NULL)

 		return;

 

-	HANDLE hImage = (HANDLE) -1;

+	HANDLE hImage = INVALID_HANDLE_VALUE;

 

 	DBVARIANT dbv = { 0 };

 	if (!DBGetContactSettingString(hContact, MODULE_NAME, name.c_str(), &dbv))

@@ -85,7 +85,7 @@ int IcolibExtraIcon::setIcon(int id, HANDLE hContact, void *icon)
 

 		HANDLE hImage;

 		if (IsEmpty(icolibName))

-			hImage = (HANDLE) -1;

+			hImage = INVALID_HANDLE_VALUE;

 		else

 			hImage = AddIcon(icolibName);

 

diff --git a/Plugins/extraicons/options.cpp b/Plugins/extraicons/options.cpp
index 0d9114e..2f2b6a3 100644
--- a/Plugins/extraicons/options.cpp
+++ b/Plugins/extraicons/options.cpp
@@ -91,7 +91,7 @@ static void RemoveExtraIcons(int slot)
 	HANDLE hContact = (HANDLE) CallService(MS_DB_CONTACT_FINDFIRST, 0, 0);

 	while (hContact != NULL)

 	{

-		Clist_SetExtraIcon(hContact, slot, (HANDLE) -1);

+		Clist_SetExtraIcon(hContact, slot, INVALID_HANDLE_VALUE);

 

 		hContact = (HANDLE) CallService(MS_DB_CONTACT_FINDNEXT, (WPARAM) hContact, 0);

 	}

diff --git a/Plugins/extraicons/usedIcons.cpp b/Plugins/extraicons/usedIcons.cpp
index 27f88c7..f5b0329 100644
--- a/Plugins/extraicons/usedIcons.cpp
+++ b/Plugins/extraicons/usedIcons.cpp
@@ -26,7 +26,7 @@ struct Icon
 	HANDLE hImage;

 

 	Icon(const char *icolibName) :

-		name(icolibName), refCount(0), hImage((HANDLE) -1)

+		name(icolibName), refCount(0), hImage(INVALID_HANDLE_VALUE)

 	{

 	}

 };

@@ -53,7 +53,7 @@ static Icon * FindIcon(const char *icolibName)
 		icon = &usedIcons[usedIcons.size() - 1];

 	}

 

-	if (icon->hImage == (HANDLE) -1)

+	if (icon->hImage == INVALID_HANDLE_VALUE)

 	{

 		HICON hIcon = IcoLib_LoadIcon(icon->name.c_str());

 		if (hIcon != NULL)

@@ -103,6 +103,6 @@ void ResetIcons()
 	usedIcons.erase(std::remove_if(usedIcons.begin(), usedIcons.end(), NotUsedIcon), usedIcons.end());

 

 	for (unsigned int i = 0; i < usedIcons.size(); ++i)

-		usedIcons[i].hImage = (HANDLE) -1;

+		usedIcons[i].hImage = INVALID_HANDLE_VALUE;

 }