GUI change:

- methods OnInitDialog, OnApply & OnClose of CDlgBase now return true if successful. return of false prevents a dialog from being loaded or left respectively;
- massive code cleaning considering the 'virtual' attribute of overridden methods;
- also fixes #1476 (Don't close "Create new account" window if user not set account name)

1 files changed, 4 insertions, 2 deletions

diff --git a/plugins/Db3x_mmap/src/ui.h b/plugins/Db3x_mmap/src/ui.h
index 09e27961f8..83d7d3dbb4 100644
--- a/plugins/Db3x_mmap/src/ui.h
+++ b/plugins/Db3x_mmap/src/ui.h
@@ -19,7 +19,7 @@ public:
 		m_combo.OnChange = Callback(this, &CSelectCryptoDialog::OnComboChanged);

 	}

 

-	void OnInitDialog()

+	bool OnInitDialog() override

 	{

 		for (size_t i = 0; i < m_provscount; i++)

 		{

@@ -28,11 +28,13 @@ public:
 		}

 		m_combo.SetCurSel(0);

 		SetDescr(m_provs[0]);

+		return true;

 	}

 

-	void OnClose()

+	bool OnClose() override

 	{

 		m_selected = m_provs[ m_combo.GetItemData(m_combo.GetCurSel()) ];

+		return true;

 	}

 

 	void OnComboChanged(CCtrlCombo*)