fixes #4109 (Прекратить хранение списка групп в базе)

4 files changed, 155 insertions, 141 deletions

diff --git a/src/mir_app/src/clc.cpp b/src/mir_app/src/clc.cpp
index b52c63f672..48a54d8745 100644
--- a/src/mir_app/src/clc.cpp
+++ b/src/mir_app/src/clc.cpp
@@ -69,15 +69,6 @@ extern bool g_bGroupsLocked;
 static int ClcSettingChanged(WPARAM hContact, LPARAM lParam)

 {

 	DBCONTACTWRITESETTING *cws = (DBCONTACTWRITESETTING *)lParam;

-	if (hContact == 0) {

-		if (!strcmp(cws->szModule, "CListGroups")) {

-			if (g_bGroupsLocked)

-				Clist_Broadcast(CLM_AUTOREBUILD, 0, 0);

-			else

-				Clist_Broadcast(INTM_GROUPSCHANGED, hContact, lParam);

-		}

-		return 0;

-	}

 

 	if (!strcmp(cws->szModule, "CList")) {

 		if (!strcmp(cws->szSetting, "MyHandle")) {

@@ -361,40 +352,32 @@ LRESULT CALLBACK fnContactListControlWndProc(HWND hwnd, UINT uMsg, WPARAM wParam
 		return (LRESULT)dat->fontInfo[FONTID_CONTACTS].hFont;

 

 	case INTM_GROUPSCHANGED:

-		{

-			DBCONTACTWRITESETTING *dbcws = (DBCONTACTWRITESETTING *)lParam;

-			if (dbcws->value.type == DBVT_ASCIIZ || dbcws->value.type == DBVT_UTF8) {

-				int groupId = atoi(dbcws->szSetting) + 1;

-

-				// check name of group and ignore message if just being expanded/collapsed

-				if (Clist_FindItem(hwnd, dat, groupId | HCONTACT_ISGROUP, &contact, &group)) {

-					CMStringW szFullName(contact->szText);

-					while (group->parent) {

-						ClcContact *cc = nullptr;

-						for (auto &it : group->parent->cl)

-							if (it->group == group) {

-								cc = it;

-								break;

-							}

-

-						if (cc == nullptr) {

-							szFullName.Empty();

-							break;

-						}

-						szFullName = CMStringW(cc->szText) + L"\\" + szFullName;

-						group = group->parent;

-					}

+		if (auto *pGroup = (CGroupInternal *)lParam) {

+			// check name of group and ignore message if just being expanded/collapsed

+			if (!Clist_FindItem(hwnd, dat, pGroup->groupId | HCONTACT_ISGROUP, &contact, &group))

+				break;

 

-					int eq;

-					if (dbcws->value.type == DBVT_ASCIIZ)

-						eq = !mir_wstrcmp(szFullName, _A2T(dbcws->value.pszVal + 1));

-					else

-						eq = !mir_wstrcmp(szFullName, ptrW(mir_utf8decodeW(dbcws->value.pszVal + 1)));

+			CMStringW szFullName(contact->szText);

+			while (group->parent) {

+				ClcContact *cc = nullptr;

+				for (auto &it : group->parent->cl)

+					if (it->group == group) {

+						cc = it;

+						break;

+					}

 

-					if (eq && contact->group->bHideOffline == ((dbcws->value.pszVal[0] & GROUPF_HIDEOFFLINE) != 0))

-						break;  //only expanded has changed: no action reqd

+				if (cc == nullptr) {

+					szFullName.Empty();

+					break;

 				}

+				szFullName = CMStringW(cc->szText) + L"\\" + szFullName;

+				group = group->parent;

 			}

+

+			bool eq = !mir_wstrcmp(szFullName, pGroup->groupName);

+			if (eq && contact->group->bHideOffline == ((pGroup->flags & GROUPF_HIDEOFFLINE) != 0))

+				break;  // only expanded has changed: no action reqd

+

 			Clist_SaveStateAndRebuildList(hwnd, dat);

 		}

 		break;

diff --git a/src/mir_app/src/clc.h b/src/mir_app/src/clc.h
index 9231e8cc18..37a54fb0d6 100644
--- a/src/mir_app/src/clc.h
+++ b/src/mir_app/src/clc.h
@@ -168,3 +168,17 @@ int fnSetHideOffline(int iValue);
 

 /* docking.c */

 int fnDocking_ProcessWindowMessage(WPARAM wParam, LPARAM lParam);

+

+// clistgroups.cpp

+

+struct CGroupInternal

+{

+	CGroupInternal(int _id, const wchar_t *_name, int _flags);

+	~CGroupInternal();

+

+	int groupId, oldId = -1, flags;

+	bool bSaveExpanded;

+	wchar_t *groupName;

+

+	void save();

+};

diff --git a/src/mir_app/src/clistgroups.cpp b/src/mir_app/src/clistgroups.cpp
index 174d4a3289..8bc65e137e 100644
--- a/src/mir_app/src/clistgroups.cpp
+++ b/src/mir_app/src/clistgroups.cpp
@@ -27,30 +27,10 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 

 #define MAX_GROUPNAME_LEN 256

 

-struct CGroupInternal

-{

-	CGroupInternal(int _id, const wchar_t *_name) :

-		groupId(_id),

-		groupName(mir_wstrdup(_name))

-	{

-		bSaveExpanded = (groupName[0] & GROUPF_EXPANDED) != 0;

-	}

-

-	~CGroupInternal()

-	{	mir_free(groupName);

-	}

-

-	int groupId, oldId = -1;

-	bool bSaveExpanded;

-	wchar_t *groupName;

+HANDLE hGroupChangeEvent;

+bool g_bGroupsLocked = false;

 

-	void save()

-	{

-		char idstr[33];

-		itoa(groupId, idstr, 10);

-		db_set_ws(0, "CListGroups", idstr, groupName);

-	}

-};

+static mir_cs csGroups;

 

 /////////////////////////////////////////////////////////////////////////////////////////

 

@@ -62,25 +42,57 @@ static LIST<CGroupInternal> arByName(20, CompareGrpByName);
 

 /////////////////////////////////////////////////////////////////////////////////////////

 

-struct CGroupList : public LIST<CGroupInternal>

+LIST<CGroupInternal> arByIds(20, NumericKeySortT);

+

+static CGroupInternal* FindGroup(int key)

+{

+	return arByIds.find((CGroupInternal *)&key);

+}

+

+/////////////////////////////////////////////////////////////////////////////////////////

+

+static CTimer *g_pTimer;

+

+struct CGroupImpl

 {

-	CGroupList() :

-		LIST<CGroupInternal>(20, NumericKeySortT)

-		{}

+	void OnTimer(CTimer *)

+	{

+		g_pTimer->Stop();

 

-	__inline CGroupInternal* find(int key)

-	{	return LIST<CGroupInternal>::find((CGroupInternal*)&key);

-	}

-};

+		JSONNode root(JSON_ARRAY);

+		for (auto &it : arByIds) {

+			JSONNode grp;

+			grp << INT_PARAM("id", it->groupId) << WCHAR_PARAM("name", it->groupName) << INT_PARAM("flags", it->flags);

+			root << grp;

+		}

 

-static CGroupList arByIds;

+		json2file(root, VARSW(L"%miranda_userdata%\\groups.json"));

+	}

+}

+g_impl;

 

 /////////////////////////////////////////////////////////////////////////////////////////

+// CGroupInternal members

 

-HANDLE hGroupChangeEvent;

-bool g_bGroupsLocked = false;

+CGroupInternal::CGroupInternal(int _id, const wchar_t *_name, int _flags) :

+	flags(_flags),

+	groupId(_id),

+	groupName(mir_wstrdup(_name))

+{

+	bSaveExpanded = (_flags & GROUPF_EXPANDED) != 0;

+}

 

-static mir_cs csGroups;

+CGroupInternal::~CGroupInternal()

+{

+	mir_free(groupName);

+}

+

+void CGroupInternal::save()

+{

+	Clist_Broadcast(INTM_GROUPSCHANGED, 0, LPARAM(this));

+

+	g_pTimer->Start(1000);

+}

 

 /////////////////////////////////////////////////////////////////////////////////////////

 

@@ -89,11 +101,8 @@ static int GroupNameExists(const wchar_t *ptszGroupName, int skipGroup)
 	if (ptszGroupName == nullptr)

 		return 0;

 

-	wchar_t str[256];

-	wcsncpy_s(str + 1, _countof(str) - 1, ptszGroupName, _TRUNCATE);

-

 	CGroupInternal *tmp = (CGroupInternal*)_alloca(sizeof(CGroupInternal));

-	tmp->groupName = (wchar_t*)str;

+	tmp->groupName = (wchar_t*)ptszGroupName;

 	if (tmp = arByName.find(tmp))

 		return (skipGroup == tmp->groupId) ? 0 : tmp->groupId + 1;

 	return 0;

@@ -112,35 +121,34 @@ static INT_PTR CreateGroupInternal(MGROUP hParent, const wchar_t *ptszName)
 

 	const wchar_t *grpName = ptszName ? ptszName : TranslateT("New group");

 	if (hParent) {

-		CGroupInternal *tmp = arByIds.find(hParent-1);

+		CGroupInternal *tmp = FindGroup(hParent-1);

 		if (tmp == nullptr)

 			return 0;

 

-		mir_snwprintf(newBaseName, L"%s\\%s", tmp->groupName+1, grpName);

+		mir_snwprintf(newBaseName, L"%s\\%s", tmp->groupName, grpName);

 	}

 	else wcsncpy_s(newBaseName, grpName, _TRUNCATE);

 

-	mir_wstrncpy(newName + 1, newBaseName, _countof(newName) - 1);

+	mir_wstrncpy(newName, newBaseName, _countof(newName) - 1);

 	if (ptszName) {

 		int id = GroupNameExists(newBaseName, -1);

 		if (id)

 			return id;

 	}

 	else {

-		for (int idCopy = 1; GroupNameExists(newName + 1, -1); idCopy++)

-			mir_snwprintf(newName + 1, _countof(newName) - 1, L"%s (%d)", newBaseName, idCopy);

+		for (int idCopy = 1; GroupNameExists(newName, -1); idCopy++)

+			mir_snwprintf(newName, L"%s (%d)", newBaseName, idCopy);

 	}

 

 	int newId = arByIds.getCount();

-	newName[0] = 1 | GROUPF_EXPANDED;   // 1 is required so we never get '\0'

-	CGroupInternal *pNew = new CGroupInternal(newId, newName);

+	CGroupInternal *pNew = new CGroupInternal(newId, newName, GROUPF_EXPANDED);

 	arByIds.insert(pNew);

 	arByName.insert(pNew);

 	pNew->save();

 

 	Clist_GroupAdded(newId + 1);

 

-	CLISTGROUPCHANGE grpChg = { nullptr, newName+1 };

+	CLISTGROUPCHANGE grpChg = { nullptr, newName };

 	NotifyEventHooks(hGroupChangeEvent, 0, (LPARAM)&grpChg);

 

 	return newId + 1;

@@ -170,13 +178,13 @@ MIR_APP_DLL(MGROUP) Clist_GroupCreate(MGROUP hParent, LPCTSTR ptszGroupName)
 

 MIR_APP_DLL(wchar_t*) Clist_GroupGetName(MGROUP hGroup, uint32_t *pdwFlags)

 {

-	CGroupInternal *p = arByIds.find(hGroup-1);

+	CGroupInternal *p = FindGroup(hGroup-1);

 	if (p == nullptr)

 		return nullptr;

 

 	if (pdwFlags != nullptr)

-		*pdwFlags = p->groupName[0] & ~1;

-	return p->groupName+1;

+		*pdwFlags = p->flags;

+	return p->groupName;

 }

 

 /////////////////////////////////////////////////////////////////////////////////////////

@@ -198,13 +206,13 @@ static bool isParentOf(const CMStringW &pParent, const wchar_t *p)
 MIR_APP_DLL(int) Clist_GroupDelete(MGROUP hGroup)

 {

 	// get the name

-	CGroupInternal *pGroup = arByIds.find(hGroup-1);

+	CGroupInternal *pGroup = FindGroup(hGroup-1);

 	if (pGroup == nullptr)

 		return 1;

 

 	if (Clist::ConfirmDelete) {

 		wchar_t szQuestion[256 + 100];

-		mir_snwprintf(szQuestion, TranslateT("Are you sure you want to delete group '%s'? This operation cannot be undone."), pGroup->groupName+1);

+		mir_snwprintf(szQuestion, TranslateT("Are you sure you want to delete group '%s'? This operation cannot be undone."), pGroup->groupName);

 		if (MessageBoxW(g_clistApi.hwndContactList, szQuestion, TranslateT("Delete group"), MB_YESNO | MB_ICONQUESTION) == IDNO)

 			return 1;

 	}

@@ -213,7 +221,7 @@ MIR_APP_DLL(int) Clist_GroupDelete(MGROUP hGroup)
 	

 	// must remove setting from all child contacts too

 	// children are demoted to the next group up, not deleted.

-	CMStringW wszOldName(pGroup->groupName + 1), wszNewParent;

+	CMStringW wszOldName(pGroup->groupName), wszNewParent;

 	{

 		int idx = wszOldName.ReverseFind('\\');

 		if (idx != -1)

@@ -239,7 +247,7 @@ MIR_APP_DLL(int) Clist_GroupDelete(MGROUP hGroup)
 

 	int iGap = 0;

 	for (auto &it : arByIds.rev_iter()) {

-		if (!isParentOf(wszOldName, it->groupName + 1))

+		if (!isParentOf(wszOldName, it->groupName))

 			continue;

 

 		iGap++;

@@ -253,12 +261,6 @@ MIR_APP_DLL(int) Clist_GroupDelete(MGROUP hGroup)
 			it->save();

 	}

 

-	for (int i = 0; i < iGap; i++) {

-		char idstr[33];

-		_itoa(arByIds.getCount()+i, idstr, 10);

-		db_unset(0, "CListGroups", idstr);

-	}

-

 	SetCursor(LoadCursor(nullptr, IDC_ARROW));

 	Clist_LoadContactTree();

 

@@ -277,7 +279,7 @@ MIR_APP_DLL(int) Clist_GroupMoveBefore(MGROUP hGroup, MGROUP hGroupBefore)
 		return 0;

 

 	hGroup--;

-	CGroupInternal *pGroup = arByIds.find(hGroup);

+	CGroupInternal *pGroup = FindGroup(hGroup);

 	if (pGroup == nullptr)

 		return 0;

 

@@ -290,7 +292,7 @@ MIR_APP_DLL(int) Clist_GroupMoveBefore(MGROUP hGroup, MGROUP hGroupBefore)
 	}

 	else {

 		hGroupBefore--;

-		CGroupInternal *pDest = arByIds.find(hGroupBefore);

+		CGroupInternal *pDest = FindGroup(hGroupBefore);

 		if (pDest == nullptr)

 			return 0;

 

@@ -333,17 +335,16 @@ static int RenameGroupWithMove(int groupId, const wchar_t *szName, int move)
 		return 1;

 	}

 

-	CGroupInternal *pGroup = arByIds.find(groupId);

+	CGroupInternal *pGroup = FindGroup(groupId);

 	if (pGroup == nullptr)

 		return 0;

 

 	// do the change

-	wchar_t *oldName = NEWWSTR_ALLOCA(pGroup->groupName+1);

+	wchar_t *oldName = NEWWSTR_ALLOCA(pGroup->groupName);

 	arByName.remove(pGroup);

 

 	wchar_t str[256];

-	str[0] = pGroup->groupName[0];

-	mir_wstrncpy(str + 1, szName, _countof(str) - 1);

+	mir_wstrncpy(str, szName, _countof(str));

 

 	replaceStrW(pGroup->groupName, str);

 	pGroup->save();

@@ -365,9 +366,9 @@ static int RenameGroupWithMove(int groupId, const wchar_t *szName, int move)
 			continue;

 

 		CGroupInternal *p = arByIds[i];

-		if (!wcsncmp(p->groupName+1, oldName, len) && p->groupName[len+1] == '\\' && wcschr(p->groupName + len + 2, '\\') == nullptr) {

+		if (!wcsncmp(p->groupName, oldName, len) && p->groupName[len] == '\\' && wcschr(p->groupName + len + 1, '\\') == nullptr) {

 			wchar_t szNewName[256];

-			mir_snwprintf(szNewName, L"%s\\%s", szName, p->groupName + len + 2);

+			mir_snwprintf(szNewName, L"%s\\%s", szName, p->groupName + len + 1);

 			RenameGroupWithMove(i, szNewName, 0); // luckily, child groups will never need reordering

 		}

 	}

@@ -380,7 +381,7 @@ static int RenameGroupWithMove(int groupId, const wchar_t *szName, int move)
 			*pszLastBackslash = '\0';

 			for (int i = 0; i < arByIds.getCount(); i++) {

 				CGroupInternal *p = arByIds[i];

-				if (!mir_wstrcmp(p->groupName+1, str)) {

+				if (!mir_wstrcmp(p->groupName, str)) {

 					if (i >= groupId)

 						Clist_GroupMoveBefore(groupId + 1, i + 2);

 					break;

@@ -404,16 +405,16 @@ MIR_APP_DLL(int) Clist_GroupRename(MGROUP hGroup, const wchar_t *ptszNewName)
 MIR_APP_DLL(void) Clist_GroupSaveExpanded()

 {

 	for (auto &it : arByIds)

-		it->bSaveExpanded = (it->groupName[0] & GROUPF_EXPANDED) != 0;

+		it->bSaveExpanded = (it->flags & GROUPF_EXPANDED) != 0;

 }

 

 MIR_APP_DLL(void) Clist_GroupRestoreExpanded()

 {

 	for (auto &it : arByIds) {

 		if (it->bSaveExpanded)

-			it->groupName[0] |= GROUPF_EXPANDED;

+			it->flags |= GROUPF_EXPANDED;

 		else

-			it->groupName[0] &= ~GROUPF_EXPANDED;

+			it->flags &= ~GROUPF_EXPANDED;

 		it->save();

 	}

 }

@@ -422,14 +423,14 @@ MIR_APP_DLL(void) Clist_GroupRestoreExpanded()
 

 MIR_APP_DLL(int) Clist_GroupSetExpanded(MGROUP hGroup, int iNewState)

 {

-	CGroupInternal *pGroup = arByIds.find(hGroup-1);

+	CGroupInternal *pGroup = FindGroup(hGroup-1);

 	if (pGroup == nullptr)

 		return 1;

 

 	if (iNewState)

-		pGroup->groupName[0] |= GROUPF_EXPANDED;

+		pGroup->flags |= GROUPF_EXPANDED;

 	else

-		pGroup->groupName[0] &= ~GROUPF_EXPANDED;

+		pGroup->flags &= ~GROUPF_EXPANDED;

 	pGroup->save();

 	return 0;

 }

@@ -438,16 +439,16 @@ MIR_APP_DLL(int) Clist_GroupSetExpanded(MGROUP hGroup, int iNewState)
 

 MIR_APP_DLL(int) Clist_GroupSetFlags(MGROUP hGroup, LPARAM iNewFlags)

 {

-	CGroupInternal *pGroup = arByIds.find(hGroup-1);

+	CGroupInternal *pGroup = FindGroup(hGroup-1);

 	if (pGroup == nullptr)

 		return 1;

 

 	int flags = LOWORD(iNewFlags) & HIWORD(iNewFlags);

-	int oldval = pGroup->groupName[0];

-	pGroup->groupName[0] = ((oldval & ~HIWORD(iNewFlags)) | flags) & 0x7f;

+	int oldval = pGroup->flags;

+	pGroup->flags = ((oldval & ~HIWORD(iNewFlags)) | flags) & 0x7f;

 	pGroup->save();

 

-	if ((oldval & GROUPF_HIDEOFFLINE) != (pGroup->groupName[0] & GROUPF_HIDEOFFLINE))

+	if ((oldval & GROUPF_HIDEOFFLINE) != (pGroup->flags & GROUPF_HIDEOFFLINE))

 		Clist_LoadContactTree();

 	return 0;

 }

@@ -479,7 +480,7 @@ MIR_APP_DLL(HMENU) Clist_GroupBuildMenu(int startId)
 

 	HMENU hRootMenu = CreateMenu();

 	for (int i = 0; i < arByIds.getCount(); i++) {

-		const wchar_t *pNextField = arByIds[i]->groupName + 1;

+		const wchar_t *pNextField = arByIds[i]->groupName;

 		HMENU hThisMenu = hRootMenu;

 

 		MENUITEMINFO mii = { 0 };

@@ -554,18 +555,38 @@ MIR_APP_DLL(HMENU) Clist_GroupBuildMenu(int startId)
 	return hRootMenu;

 }

 

+/////////////////////////////////////////////////////////////////////////////////////////

+// Module entry point

+

 int InitGroupServices(void)

 {

-	for (int i = 0;; i++) {

+	g_pTimer = new CTimer(Miranda_GetSystemWindow(), UINT_PTR(&g_pTimer));

+	g_pTimer->OnEvent = Callback(&g_impl, &CGroupImpl::OnTimer);

+

+	if (!db_get_b(0, "Compatibility", "Groups")) {

 		char str[32];

-		_itoa(i, str, 10);

-		ptrW tszGroup(db_get_wsa(0, "CListGroups", str));

-		if (tszGroup == nullptr)

-			break;

-

-		CGroupInternal *p = new CGroupInternal(i, tszGroup);

-		arByIds.insert(p);

-		arByName.insert(p);

+		for (int i = 0;; i++) {

+			_itoa(i, str, 10);

+			ptrW tszGroup(db_get_wsa(0, "CListGroups", str));

+			if (tszGroup == nullptr)

+				break;

+

+			auto *p = new CGroupInternal(i, tszGroup.get() + 1, tszGroup[0] & ~1);

+			arByIds.insert(p);

+			arByName.insert(p);

+		}

+		db_set_b(0, "Compatibility", "Groups", 1);

+		db_delete_module(0, "CListGroups");

+	}

+	else {

+		JSONNode cache;

+		if (file2json(VARSW(L"%miranda_userdata%\\groups.json"), cache)) {

+			for (auto &it : cache) {

+				CGroupInternal *p = new CGroupInternal(it["id"].as_int(), it["name"].as_mstring(), it["flags"].as_int());

+				arByIds.insert(p);

+				arByName.insert(p);

+			}

+		}

 	}

 

 	hGroupChangeEvent = CreateHookableEvent(ME_CLIST_GROUPCHANGE);

@@ -574,6 +595,9 @@ int InitGroupServices(void)
 

 void UninitGroupServices(void)

 {

+	g_pTimer->OnTimer();

+	delete g_pTimer;

+

 	for (auto &p : arByIds)

 		delete p;

 

diff --git a/src/mir_app/src/movetogroup.cpp b/src/mir_app/src/movetogroup.cpp
index 577f46591f..212546b391 100644
--- a/src/mir_app/src/movetogroup.cpp
+++ b/src/mir_app/src/movetogroup.cpp
@@ -23,6 +23,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

 

 #include "stdafx.h"

+#include "clc.h"

 

 static HGENMENU hMoveToGroupItem = nullptr, hPriorityItem = nullptr, hFloatingItem = nullptr;

 static LIST<HANDLE> lphGroupsItems(5);

@@ -85,6 +86,8 @@ static void AddGroupItem(HGENMENU hRoot, wchar_t* name, int pos, WPARAM param, b
 // wparam - hcontact

 // lparam .popupposition from TMO_MenuItem

 

+extern LIST<CGroupInternal> arByIds;

+

 static int OnContactMenuBuild(WPARAM wParam, LPARAM)

 {

 	OBJLIST<GroupItemSort> groups(10, GroupItemSort::compare);

@@ -100,19 +103,9 @@ static int OnContactMenuBuild(WPARAM wParam, LPARAM)
 

 	pos += 100000; // Separator

 

-	for (int i = 0;; i++) {

-		char intname[20];

-		_itoa(i, intname, 10);

-

-		DBVARIANT dbv;

-		if (db_get_ws(0, "CListGroups", intname, &dbv))

-			break;

-

-		if (dbv.pwszVal[0])

-			groups.insert(new GroupItemSort(dbv.pwszVal + 1, i + 1));

-

-		mir_free(dbv.pwszVal);

-	}

+	for (auto &it : arByIds)

+		if (it->flags)

+			groups.insert(new GroupItemSort(it->groupName, it->groupId));

 

 	for (auto &p : groups) {

 		bool checked = szContactGroup && !mir_wstrcmp(szContactGroup, p->name);